Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reference count code lens opt-in #893

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jan 6, 2022

After recent changes there's an increased overhead of pre-calculating the number of references for the code lens.

We can therefore make this code lens opt-in to avoid the extra lookups which are likely causing the excessive CPU consumption as code lens get refresh upon editor focus and generally very often.

This should help address hashicorp/terraform-ls#733

@radeksimko radeksimko marked this pull request as ready for review January 6, 2022 17:59
@radeksimko radeksimko requested a review from a team January 6, 2022 17:59
@radeksimko radeksimko merged commit 424f77a into main Jan 6, 2022
@radeksimko radeksimko deleted the f-refcount-opt-in branch January 6, 2022 18:04
@github-actions
Copy link

github-actions bot commented Feb 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants