Update eslint and minimal ruleset #896
Conversation
This updates eslint and related plugins to latest package versions. It also brings the eslint config into line with default config published by the VS Code Extension yo template. Most of the code is compliant with the eslint rulsets, with the exception of naming convention for fields and variables. Where we could update the naming, we did. Where we could not eslint disable lines were added.
|
This partially address #849 in that it adds some default ruleset. It does not go as far as we want to yet. |
There was a problem hiding this comment.
Thank you for updating the packages and adding more linting rules.
@typescript-eslint/naming-convention got me thinking. I don't particularly appreciate having eslint-disable comments in the code and wondered why we need that much. The LSP spec is using camelcase for all attributes on the RPC calls, but we missed doing this for our custom commands :/
For future commands, we might want to use camelcase for the JSON attributes in the go code and revisit our existing commands at some point.
|
Yep. We missed the chance before, and changing now would require a tandem client/ls release. Which is not easy now but will be when platform specific extension lands. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
This updates eslint and related plugins to latest package versions. It also brings the eslint config into line with default config published by the VS Code Extension yo template.
Most of the code is compliant with the eslint rulsets, with the exception of naming convention for fields and variables. Where we could update the naming, we did. Where we could not eslint disable lines were added.