Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm run syntax tests #928

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Fix npm run syntax tests #928

merged 1 commit into from
Feb 9, 2022

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Feb 9, 2022

This changes the single quotes to double quotes in the syntax and grammar scripts.

Single quotes do not work on Windows, double quotes work everywhere and allow passing in arguments using npm run test:snap -- -u

This changes the single quotes to double quotes in the syntax and grammar scripts.

Single quotes do not work on Windows, double quotes work everywhere and allow passing in arguments using `npm run test:snap -- -u`
@jpogran jpogran self-assigned this Feb 9, 2022
@jpogran jpogran requested review from dbanck and radeksimko and removed request for dbanck February 9, 2022 17:39
@jpogran jpogran added the ci Continuous integration/delivery related label Feb 9, 2022
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no! Sorry, I didn't think of this in #917

@jpogran jpogran merged commit 39e25f1 into main Feb 9, 2022
@jpogran jpogran deleted the fix_syntax_script_runner branch February 9, 2022 17:45
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@jpogran jpogran added this to the 2.20.0 milestone Feb 18, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci Continuous integration/delivery related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants