Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Extension Documentation #942

Merged
merged 24 commits into from
Feb 28, 2022
Merged

Improve Extension Documentation #942

merged 24 commits into from
Feb 28, 2022

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Feb 23, 2022

This PR updates the README with more user focused documentation about extension usage, features, troubleshooting info, an improved quick start, and more detailed workflow scenarios. The aim is to be as comprehensive and helpful as possible without going into dedicated website territory.

To do this required significantly changing the order and content of the sections. This allows us to have linkable headers that we can provide in tickets and when interacting with our community.

It also adds example screenshots of features in use. These are purposely ignored by the packaging command to save space in the VSIX. They are referenced using Markdown links that will be automatically translated by vsce when packaging, so will be available to internet connected clients when viewed inside the Extension pane. If there is no internet, they won't be resolvable, but that is a small price to pay for a small install size.

This also includes corrected and/or updated information that replaces the following Wiki pages:

@jpogran jpogran changed the title update readme Improve Extension Documentation Feb 23, 2022
@jpogran jpogran force-pushed the update_readme branch 2 times, most recently from dd61013 to 3bafc8e Compare February 23, 2022 20:42
@jpogran jpogran self-assigned this Feb 23, 2022
@jpogran jpogran added the documentation Improvements or additions to documentation label Feb 23, 2022
@jpogran jpogran added this to the 2.20.0 milestone Feb 23, 2022
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! This is super helpful!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
DEVELOPMENT.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
Comment on lines 159 to 165
### Refresh Intellisense

To provide the extension with an up-to-date schema for the Terraform providers used in your configuration:

1. Open a terminal and change the current working directory to your desired workspace and/or the root folder containing your Terraform files.
1. Perform a `terraform init` from the terminal.
1. Open VS Code in the current working directory by typing `code .`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW the language server should be able to pick up new providers automatically whenever anything changes in .terraform, so init should actually be sufficient here - there should be no need to restart VSCode.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was hard to figure out. The original documentation was from when we had to run init outside the editor and I was trying to reconcile that with current experience. I'll edit this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jpogran jpogran marked this pull request as ready for review February 25, 2022 17:23
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great README update!

I've commented on some minor findings. Also, docs/syntax.png is unused and could be removed?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
jpogran and others added 3 commits February 28, 2022 08:38
Co-authored-by: Daniel Banck <dbanck@users.noreply.github.com>
@jpogran jpogran merged commit 9461f77 into main Feb 28, 2022
@jpogran jpogran deleted the update_readme branch February 28, 2022 14:44
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants