This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
builtin/docker: Introduce Resources map for configuring cpu, memory #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the ability to configure a containers resources limits around cpu and memory when deploying with docker. Fixes #608
krantzinator
approved these changes
Feb 19, 2021
| @@ -503,6 +525,16 @@ deploy { | |||
| ), | |||
| ) | |||
|
|
|||
| doc.SetField( | |||
| "resources", | |||
| "A map of resources to configure the container with, such as memory or cpu limits.", | |||
There was a problem hiding this comment.
nit
Suggested change
| "A map of resources to configure the container with, such as memory or cpu limits.", | |
| "A map of resources to configure the container with, such as memory or cpu limits", |
There was a problem hiding this comment.
Looking at this, it seems like some of our fields have periods, and others don't. But ultimately the docs generators adds them to the end when they get generated for the website, so maybe I'll leave this one here? Otherwise it's kind of confusing if it adds it back.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the ability to configure a containers resources
limits around cpu and memory when deploying with docker.
Fixes #608