Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Builtin: support docker deployment resource specifications #608

Closed
rugwirobaker opened this issue Oct 18, 2020 · 0 comments · Fixed by #1116
Closed

Builtin: support docker deployment resource specifications #608

rugwirobaker opened this issue Oct 18, 2020 · 0 comments · Fixed by #1116
Assignees
Labels
enhancement New feature or request plugin/docker
Milestone

Comments

@rugwirobaker
Copy link

Is your feature request related to a problem? Please describe.

There is currently no way to specify resource limits for apps that use docker.

Describe the solution you'd like
Support resource limits in the docker plugin. An example deployment stanza would look like this:

deploy {
  use "docker" {
    service_port = "8080"
    cpu = "2"
    memory = "512"
  }
}

Describe alternatives you've considered
N/A

Explain any additional use-cases
It would very useful for the docker swarm community but I also believe there is value in it for people just coming off Heroku(which takes care of everything) with a single docker host who would want to prevent a rog container consuming all their host's resources.

Additional context
N/A

@mitchellh mitchellh added enhancement New feature or request plugin/docker labels Oct 18, 2020
@briancain briancain self-assigned this Feb 18, 2021
@briancain briancain added this to the 0.2.x milestone Feb 18, 2021
briancain added a commit that referenced this issue Feb 19, 2021
This commit introduces the ability to configure a containers resources
limits around cpu and memory when deploying with docker.

Fixes #608
@krantzinator krantzinator modified the milestones: 0.2.x, 0.2.3 Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request plugin/docker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants