This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
ui: Add dynamic page titles #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I added a changelog entry. |
|
Backporting this in case there is another minor release before |
|
(Hold off merging though as we’re just in the process of releasing |
jgwhite
force-pushed
the
ui/am-page-title
branch
from
5947414
to
450a9bd
Compare
|
Was missing the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1853
Adds
ember-page-titleand names all our major routes. Follows a11y guidelines of having most unique information at the beginning of the page title. Some examples;