Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

ui: Image registry in name ends up breaking formatting #2484

Closed
briancain opened this issue Oct 14, 2021 · 5 comments · Fixed by #2518
Closed

ui: Image registry in name ends up breaking formatting #2484

briancain opened this issue Oct 14, 2021 · 5 comments · Fixed by #2518
Assignees
Labels
bug Something isn't working ui

Comments

@briancain
Copy link
Member

Describe the bug

Build a container with a local registry, like localhost:5000/image-name. Check out the UI for a deployment.

Screenshot from 2021-10-13 17-22-13

Expected behavior

It should be formatted properly

Waypoint Platform Versions
Additional version and platform information to help triage the issue if
applicable:

  • Waypoint CLI Version: main
  • Waypoint Server Platform and Version: kubernetes on main
  • Waypoint Plugin: (like aws/ecs, pack, azure)

Additional context
Add any other context about the problem here.

@briancain
Copy link
Member Author

Guessing the split on image name just needs to be adjusted:

Screenshot from 2021-10-13 17-28-26

@jgwhite
Copy link
Contributor

jgwhite commented Oct 14, 2021

Good spot. I guess we should imitate github.com/docker/distribution/reference to do this correctly (or look for JS implementation).

@briancain
Copy link
Member Author

Yep @jgwhite - we use the Go pkg from docker to do just that! Hopefully there's a JS version 🙏🏻

@jgwhite jgwhite added the bug Something isn't working label Oct 14, 2021
@jgwhite jgwhite self-assigned this Oct 19, 2021
@jgwhite
Copy link
Contributor

jgwhite commented Oct 19, 2021

I found https://github.com/retrohacker/parse-docker-image-name which is compiled from the Go with gopherjs 😅

jgwhite added a commit that referenced this issue Oct 19, 2021
jgwhite added a commit that referenced this issue Oct 19, 2021
jgwhite added a commit that referenced this issue Oct 19, 2021
jgwhite added a commit that referenced this issue Oct 19, 2021
jgwhite added a commit that referenced this issue Oct 19, 2021
jgwhite added a commit that referenced this issue Oct 20, 2021
@jgwhite
Copy link
Contributor

jgwhite commented Oct 20, 2021

I found https://github.com/retrohacker/parse-docker-image-name which is compiled from the Go with gopherjs 😅

Turns out this lib was way too big. Going for a more spritely package.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working ui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants