This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 327
ui: Image registry in name ends up breaking formatting #2484
Comments
Good spot. I guess we should imitate github.com/docker/distribution/reference to do this correctly (or look for JS implementation). |
Yep @jgwhite - we use the Go pkg from docker to do just that! Hopefully there's a JS version 🙏🏻 |
I found https://github.com/retrohacker/parse-docker-image-name which is compiled from the Go with gopherjs 😅 |
jgwhite
added a commit
that referenced
this issue
Oct 19, 2021
jgwhite
added a commit
that referenced
this issue
Oct 19, 2021
jgwhite
added a commit
that referenced
this issue
Oct 19, 2021
jgwhite
added a commit
that referenced
this issue
Oct 19, 2021
jgwhite
added a commit
that referenced
this issue
Oct 19, 2021
jgwhite
added a commit
that referenced
this issue
Oct 20, 2021
Turns out this lib was way too big. Going for a more spritely package. |
jgwhite
added a commit
that referenced
this issue
Oct 20, 2021
jgwhite
added a commit
that referenced
this issue
Oct 22, 2021
jgwhite
added a commit
that referenced
this issue
Oct 22, 2021
jgwhite
added a commit
that referenced
this issue
Oct 22, 2021
jgwhite
added a commit
that referenced
this issue
Oct 22, 2021
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
Build a container with a local registry, like
localhost:5000/image-name
. Check out the UI for a deployment.Expected behavior
It should be formatted properly
Waypoint Platform Versions
Additional version and platform information to help triage the issue if
applicable:
main
main
aws/ecs
,pack
,azure
)Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: