-
Notifications
You must be signed in to change notification settings - Fork 327
Conversation
eaa15db
to
3dbd93c
Compare
3dbd93c
to
6dc6826
Compare
9ef9a24
to
5cb29b6
Compare
5cb29b6
to
6e9539a
Compare
6e9539a
to
205156c
Compare
205156c
to
c4bbe84
Compare
c4bbe84
to
997dc6b
Compare
Looks like the prod build never completes! |
OK, |
997dc6b
to
545503b
Compare
545503b
to
0d5f06b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a comment regarding the display of the full sha: in https://github.com/hashicorp/waypoint/blob/main/ui/app/components/git-commit.hbs#L3 I display the shortened version, but use the <CopyButton>
to copy the full value. We could also update the truncate-commit
helper to use an optional named length
param with a default to 7 to make it applicable here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a comment regarding the display of the full sha: in https://github.com/hashicorp/waypoint/blob/main/ui/app/components/git-commit.hbs#L3 I display the shortened version, but use the <CopyButton>
to copy the full value. We could also update the truncate-commit
helper to use an optional named length
param with a default to 7 to make it applicable here.
Great idea. I’ll implement this before merging. |
0d5f06b
to
40ad080
Compare
40ad080
to
3c5d2a4
Compare
3c5d2a4
to
0e265aa
Compare
0e265aa
to
8da3d07
Compare
Why the change?
Closes #2484 and #2495
What’s the plan?
What does it look like?
Before
After
CleanShot.2021-10-22.at.12.39.59.mp4
How do I test it?
ui/docker-reference
image
value in the resources factorySome examples to test with: