Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Resources route #2777

Merged
merged 4 commits into from
Jan 12, 2022
Merged

Resources route #2777

merged 4 commits into from
Jan 12, 2022

Conversation

gregone
Copy link
Contributor

@gregone gregone commented Nov 25, 2021

The Artifact popover (#2740) will be visible on the resources page. But that page didn't exist, so I started creating it.

The popover PR will come later.
Screen Shot 2022-01-11 at 20 05 53

@github-actions github-actions bot added the ui label Nov 25, 2021
@github-actions
Copy link

github-actions bot commented Nov 25, 2021

Ember Asset Size action

As of e6b2d60

Files that got Bigger 🚨:

File raw gzip
vendor.js +324 B +55 B
waypoint.js +6.86 kB +491 B
waypoint.css +243 B +179 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.css 0 B 0 B

@gregone gregone force-pushed the ui/artifact-overview-popover branch from b952a4f to 23565e0 Compare January 11, 2022 19:23
@gregone gregone requested a review from a team January 11, 2022 19:23
@gregone gregone changed the title [WIP] resources route & artifact popover Resources route Jan 11, 2022
@gregone gregone marked this pull request as ready for review January 11, 2022 19:26
Copy link
Contributor

@jgwhite jgwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Only minor change requests from me.

ui/app/components/resources-table-extended.hbs Outdated Show resolved Hide resolved
ui/app/components/resources-table-extended.hbs Outdated Show resolved Hide resolved
ui/app/components/resources-table-extended.hbs Outdated Show resolved Hide resolved
ui/app/components/resources-table-extended.hbs Outdated Show resolved Hide resolved
ui/app/components/resources-table-extended.hbs Outdated Show resolved Hide resolved
ui/app/routes/workspace/projects/project/app/resources.ts Outdated Show resolved Hide resolved
@gregone
Copy link
Contributor Author

gregone commented Jan 12, 2022

@jgwhite updated with fixed for all your comments

@gregone gregone merged commit 5c3e5f0 into main Jan 12, 2022
@gregone gregone deleted the ui/artifact-overview-popover branch January 12, 2022 14:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants