Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Add release CLI options to deploy command #3592

Closed
paladin-devops opened this issue Jul 21, 2022 · 0 comments · Fixed by #4114
Closed

Add release CLI options to deploy command #3592

paladin-devops opened this issue Jul 21, 2022 · 0 comments · Fixed by #4114
Assignees
Labels

Comments

@paladin-devops
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The waypoint deploy command can also release the deployment (this is the default case). This can be toggled with the -release flag on the deploy command.

Though you can release with the deploy command, you cannot disable pruning. The -prune and -prune-retain flags are only available on the release command. Therefore, it isn't possible to disable pruning for the release that is run (by default) with the deploy command, after a deployment is done.

Describe the solution you'd like
Add the -prune and -prune-retain flags to waypoint deploy, and set them for the release operation if the release flag is set to true.

Describe alternatives you've considered
Run waypoint deploy -release=false and waypoint release -prune=false separately.

Explain any additional use-cases
Pruning may not be desired in certain situations, or for some plugins (nomad-jobspec-canary, for example).

@evanphx evanphx added core/cli and removed new labels Jul 27, 2022
@briancain briancain self-assigned this Oct 26, 2022
briancain added a commit that referenced this issue Oct 26, 2022
This commit includes the various `prune` flags for configuring an
automated release from the deploy CLI.

Fixes #3592
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants