This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Fix version check on server during ECS upgrade #3820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously during ECS upgrades, if the current server image was hashicorp/waypoint:latest, regardless of user input, the upgrade would just force-redeploy the existing ECS service and not update the image. With this change, we check the existing image to see if it matches hashicorp/waypoint:latest, AND check if that's what the user wanted to upgrade to. If either of those is false, we update the task definition during the upgrade.
briancain
reviewed
Sep 7, 2022
…heck during ECS upgrade.
briancain
approved these changes
Sep 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously during ECS upgrades, if the current server image was hashicorp/waypoint:latest, regardless of user input, the upgrade would just force-redeploy the existing ECS service and not update the image. With this change, we check the existing image to see if it matches hashicorp/waypoint:latest, AND check if that's what the user wanted to upgrade to. If either of those is false, we update the task definition during the upgrade.