Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Fix version check on server during ECS upgrade #3820

Merged
merged 4 commits into from
Sep 7, 2022
Merged

Fix version check on server during ECS upgrade #3820

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
11a7d54
Update version check on server during ECS upgrade.
paladin-devops Sep 7, 2022
4f69e5c
Changelog.
paladin-devops Sep 7, 2022
9479597
Check if container definition is nil before proceeding with version c…
paladin-devops Sep 7, 2022
5d18a03
Changelog update.
paladin-devops Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changelog/3280.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
```release-note:bug
upgrade: Update ECS server upgrade to respect -ecs-server-image flag when the
existing server image is hashicorp/waypoint:latest
```
3 changes: 1 addition & 2 deletions internal/serverinstall/ecs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,8 +536,7 @@ func (i *ECSInstaller) Upgrade(
s = sg.Add("Updating task definition")
defer func() { s.Abort() }()

// assume upgrade to latest
if *containerDef.Image == installutil.DefaultServerImage {
if *containerDef.Image == installutil.DefaultServerImage && upgradeImg == installutil.DefaultServerImage {
paladin-devops marked this conversation as resolved.
Show resolved Hide resolved
// we can just update/force-deploy the service
_, err := ecsSvc.UpdateService(&ecs.UpdateServiceInput{
ForceNewDeployment: aws.Bool(true),
Expand Down