Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

waypoint install -platform=nomad always allows dc1 as a dc #601

Closed
attachmentgenie opened this issue Oct 17, 2020 · 1 comment · Fixed by #603
Closed

waypoint install -platform=nomad always allows dc1 as a dc #601

attachmentgenie opened this issue Oct 17, 2020 · 1 comment · Fixed by #603
Labels
bug Something isn't working core

Comments

@attachmentgenie
Copy link

attachmentgenie commented Oct 17, 2020 •
edited
Loading

Describe the bug

while installing the waypoint server to a cluster not using "dc1" as its datacenter the job that gets deployed still lists dc1 as an acceptable datacenter to be deployed into.

Steps to Reproduce

nomad agent -dev -dc=notdc1 -network-interface=eno1
waypoint install -platform=nomad -nomad-dc=notdc1 -accept-tos

review http://localhost:4646/ui/jobs/waypoint-server/definition

{
....
  "Datacenters": [
    "dc1",
    "notdc1"
  ],
...
}

Expected behavior
To only have "notdc1" in the list of acceptable datacenters
@attachmentgenie
Copy link
Author

seems to be caused by

https://github.com/hashicorp/waypoint/blob/7e712c27a8f0537d8bbdc6e04835f9d97260e290/internal/pkg/flag/flag_string_slice.go#L33,L35

@mitchellh mitchellh added bug Something isn't working core labels Oct 17, 2020
mitchellh added a commit that referenced this issue Oct 17, 2020
@mitchellh
internal/pkg/flag: string slice defaults only if no flags given
81e8af0 
Fixes #601

We should only use the default string slice value if no flags are given.
Nomad is currently the only user of this flag and this is the expected
behavior there, plus I believe elsewhere.
@mitchellh mitchellh mentioned this issue Oct 17, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

internal/pkg/flag: string slice defaults only if no flags given hashicorp/waypoint
2 participants
@mitchellh @attachmentgenie