This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
plugin/nomad: Ensure Namespace is set if not set by user #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we have to pass through namespace as a ptr, if namespace is unset then it gets dereferenced as empty string rather than nil, which means the Nomad job api `Canonicalize()` doesn't end up setting a default namespace. This commit fixes that by ensuring the namespace Waypoint provides is set to a default.
briancain
added
bug
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have to pass through namespace as a ptr, if namespace is unset
then it gets dereferenced as empty string rather than nil, which means
the Nomad job api
Canonicalize()doesn't end up setting a defaultnamespace. This commit fixes that by ensuring the namespace Waypoint
provides is set to a default.