Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Feature: CLI list deployments shows health for each entry #1594

Merged
merged 10 commits into from
Jun 10, 2021
Merged

Feature: CLI list deployments shows health for each entry #1594

merged 10 commits into from
Jun 10, 2021
+1,281 −1,247

Commits on Jun 9, 2021

  1. CLI list deployments shows health for each entry 

    In writing this, I realize that our ListStatusReports endpoing lists _all_ status reports for all resources, with no way to filter. We'll probably need to enhance that pretty soon as we build up more report types and volume.

Also it looks like this is a big protobuf diff. The existing generated code has "unknown" protobuf version, so i'm not sure what version I need to revert to to make it match.
    @izaaklauer
    izaaklauer committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    710ac18 View commit details
    Browse the repository at this point in the history

  2. changelog

    @izaaklauer
    izaaklauer committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    6358475 View commit details
    Browse the repository at this point in the history

  3. Update internal/server/proto/server.proto 

    Co-authored-by: Jamie White <jamie@jgwhite.co.uk>
    @izaaklauer @jgwhite
    izaaklauer and jgwhite committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    93b45df View commit details
    Browse the repository at this point in the history

  4. Change TimeGenerated to GeneratedTime to match convention 

    Regenerated protobufs
    @izaaklauer
    izaaklauer committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    f2f1355 View commit details
    Browse the repository at this point in the history

  5. Testing the timestamp change

    @izaaklauer
    izaaklauer committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    45572ea View commit details
    Browse the repository at this point in the history

  6. Unimplemented status report "Unknown Status" -> "n/a" 

    Previously, if a plugin does not return status reports, we would say "Unknown Status", which is a bit wordy and also conflicts with the "UNKNOWN" official status, where a plugin _has tried_ to get status and is explicitly returning unknown.

"n/a" kind of implies that the very concept of health doesn't apply to some deployments, which isn't right either, but it's the least-worst thing I can think of.
    @izaaklauer
    izaaklauer committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    1f7e6bb View commit details
    Browse the repository at this point in the history

  7. Protobuf comments and field order 

    Also looping in Rae's fix (https://github.com/hashicorp/waypoint/pull/1596/files)
    @izaaklauer
    izaaklauer committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    2716ae6 View commit details
    Browse the repository at this point in the history

  8. Re-adding some error handling

    @izaaklauer
    izaaklauer committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    498c3e3 View commit details
    Browse the repository at this point in the history

  9. Fixing import order

    @izaaklauer
    izaaklauer committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    ddb18b4 View commit details
    Browse the repository at this point in the history

  10. Use new sdk version with GeneratedTime

    @izaaklauer
    izaaklauer committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    565d7ae View commit details
    Browse the repository at this point in the history