Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Inspecting boolean env var values. #1699

Merged
merged 14 commits into from
Jun 30, 2021
Merged

Inspecting boolean env var values. #1699

merged 14 commits into from
Jun 30, 2021

Commits on Jun 23, 2021

  1. Inspecting boolean env var values. 

    Previously, we were taking any value for boolean env vars to mean "true". If someone specified `WAYPOINT_SERVER_TLS=false`, we would take that to mean true. This fixes that.

Note on the implementation - I hate to be the person to introduce a generic "util" package. If anyone has any better ideas for where to put this little function, or feels like we should just strconv in-line every time, I am open to those ideas.
    @izaaklauer
    izaaklauer committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    449904d View commit details
    Browse the repository at this point in the history

  2. Using '1' instead of 'true' for consistency

    @izaaklauer
    izaaklauer committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    3bab6f7 View commit details
    Browse the repository at this point in the history

  3. changelog

    @izaaklauer
    izaaklauer committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    5608e92 View commit details
    Browse the repository at this point in the history

  4. Updated changelog language per Clint's suggestion

    @izaaklauer
    izaaklauer committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    c8a2cbd View commit details
    Browse the repository at this point in the history

  5. Changing util to env per Brian's suggestion

    @izaaklauer
    izaaklauer committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    20ed08f View commit details
    Browse the repository at this point in the history

  6. Not being unnecessarily perscriptive about truthiness, per Rae's sugg… 

    …estion
    @izaaklauer
    izaaklauer committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    c7f0a64 View commit details
    Browse the repository at this point in the history

  7. Tests perbrian's suggestion

    @izaaklauer
    izaaklauer committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    7a15570 View commit details
    Browse the repository at this point in the history

  8. Minor tweaks

    @izaaklauer
    izaaklauer committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    b73b0fe View commit details
    Browse the repository at this point in the history

  9. go fmt

    @izaaklauer
    izaaklauer committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    f6206b3 View commit details
    Browse the repository at this point in the history

  10. Maximum boilerplate error processing

    @izaaklauer
    izaaklauer committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    f1e4ded View commit details
    Browse the repository at this point in the history

  11. using named returns

    @izaaklauer
    izaaklauer committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    1016465 View commit details
    Browse the repository at this point in the history

  12. go fmt

    @izaaklauer
    izaaklauer committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    8ecd9a9 View commit details
    Browse the repository at this point in the history

  13. GetEnvBool -> GetBool, table test

    @izaaklauer
    izaaklauer committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    19b409d View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. Removing named return values 

    And thereby conforming to our style guide.
    @izaaklauer
    izaaklauer committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    36fe4ae View commit details
    Browse the repository at this point in the history