docker: support for registry auth in deploy

[kam1sh]

Hi! This pull request adds encoded_auth setting for docker deploy.

Usage:

  deploy {
    use "docker" {
      encoded_auth = base64encode(
        jsonencode({"username": var.dockeruser, "password" : var.dockerpassword})
      )
    }
  }

closes #2243

[hashicorp-cla]

All committers have signed the CLA.

[izaaklauer]

Hi kam1sh,

Thanks for addressing this! This is a good start, but take a look at the authentication setup that we do in docker pull here. There's more work that would need to be done to read from the docker config, for example.

[kam1sh]

I moved authorization code from pushWithDocker to findAuth function, and I reused this code in platform:pullImage:
https://github.com/hashicorp/waypoint/pull/2245/files#diff-9e5a60fe38fb5bbe6aeb7810899f4bf9d43cac4da6971124bc8d2e16c6f9ba75R737

[kam1sh]

Test failed? Weird, I didn't touched this code...

[kam1sh]

@izaaklauer can you help me with failing tests, please?

[izaaklauer]

Nice work! A few more changes we'd recommend:

• Update the docker platform config to accept encoded_auth. Right now, if I try adding encoded_auth to the docker deploy stanza of waypoing.hcl, the deployment fails with Unsupported argument; An argument named "encoded_auth" is not expected here..

• I'd recommend that you refactor findAuth to be static, so you don't need to instantiate and manually configure the Registry struct just to use this one function.

Your test failure was a flake on our end - we re-ran the tests and they were successful.

[izaaklauer]

Could make ctx the first argument? That's our convention.

[izaaklauer]

It looks like this is the only part of the findAuth function that's currently being used in pullImage, because you're not setting r.config.EncodedAuth or r.config.Password.

[izaaklauer]

Apologies, that last comment should have been "Request Changes", not "Approve".

[evanphx]

This will be resolved by #2895

[xiaolin-ninja]

Closed by #2895