Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Fix overwriting default project model #2250

Merged
merged 3 commits into from
Sep 8, 2021
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/2250.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
ui: fix leaky project repository settings being reused when creating a new project
```
6 changes: 4 additions & 2 deletions ui/app/components/app-form/project-repository-settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,12 @@ export default class AppFormProjectRepositorySettings extends Component<ProjectS
@tracked project: Project.AsObject;
@tracked authCase: number;
@tracked serverHcl: boolean;
defaultProject: Project.AsObject;

constructor(owner: unknown, args: ProjectSettingsArgs) {
super(owner, args);
this.project = JSON.parse(JSON.stringify(DEFAULT_PROJECT_MODEL)) as Project.AsObject; // to ensure we're doing a deep copy
this.defaultProject = JSON.parse(JSON.stringify(DEFAULT_PROJECT_MODEL)) as Project.AsObject; // to ensure we're doing a deep copy
this.project = this.defaultProject;
let { project } = this.args;
this.populateExistingFields(project, this.project);
this.authCase = 4;
Expand Down Expand Up @@ -128,7 +130,7 @@ export default class AppFormProjectRepositorySettings extends Component<ProjectS
populateExistingFields(projectFromArgs: Project.AsObject, currentModel: Project.AsObject): void {
for (let [key, value] of Object.entries(projectFromArgs)) {
if (isEmpty(value)) {
currentModel[key] = DEFAULT_PROJECT_MODEL[key];
currentModel[key] = this.defaultProject[key];
continue;
}

Expand Down