Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Bump the ember-build-tests resource class #2297

Merged
merged 3 commits into from
Sep 14, 2021
Merged

Conversation

gregone
Copy link
Contributor

@gregone gregone commented Sep 14, 2021

Fixes: #2260

starting with medium+, we'll see if that works, otherwise we could go to large to be sure.

@gregone gregone added the pr/no-changelog No automatic changelog entry required for this pull request label Sep 14, 2021
@gregone gregone changed the title Bump the build-tests resource class Bump the ember-build-tests resource class Sep 14, 2021
@jgwhite
Copy link
Contributor

jgwhite commented Sep 14, 2021

The process still uses all available memory 🤦‍♀️ but this should give us some headroom.

image

@jgwhite jgwhite linked an issue Sep 14, 2021 that may be closed by this pull request
@jgwhite jgwhite added the ui label Sep 14, 2021
@gregone
Copy link
Contributor Author

gregone commented Sep 14, 2021

😭

@gregone
Copy link
Contributor Author

gregone commented Sep 14, 2021

@jgwhite setting JOBS=1 actually brings the memory usage back down slightly under 5GB 🥲
Screen Shot 2021-09-14 at 15 15 00

@jgwhite
Copy link
Contributor

jgwhite commented Sep 14, 2021

@jgwhite setting JOBS=1 actually brings the memory usage back down slightly under 5GB 🥲
Screen Shot 2021-09-14 at 15 15 00

It also doesn’t seem to increase the build time much. I guess Babel isn’t embarrassingly parallel.

@gregone gregone merged commit 545bf9c into main Sep 14, 2021
@gregone gregone deleted the bump-ember-build-tests-size branch September 14, 2021 16:13
@gregone gregone mentioned this pull request Sep 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr/no-changelog No automatic changelog entry required for this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests/Frontend/ember-build-tests: Unhandled error event
2 participants