This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Backport of ui: upgrade typescript to 4.4.2 into release/0.5.x #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-waypoint
deleted the
backport/ui/ember-built-tests-flapper/explicitly-handy-boa
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #2264 to be assessed for backporting due to the inclusion of the label backport/0.5.x.
The below text is copied from the body of the original PR.
Why the change?
This is a speculative fix for #2260. See investigation notes on that issue for more details.
It’s a major version bump? Is that scary?
The breaking changes in 4.0 are not so bad, so I think this is a safe upgrade.
How do I test it?
Check out the repo and try building, running, testing the repo. Verify nothing breaks and no new weird compiler warnings appear. CI should give a pretty good indication of this but the interaction between VS Code and TypeScript might cause new interesting stuff to happen.