This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Backport of Return instead of panic in code that is only used in dev into release/0.6.x #2546
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #2533 to be assessed for backporting due to the inclusion of the label backport/0.6.x.
The below text is copied from the body of the original PR.
This bit of code causes an issue in at least AWS ECS server installs using on-demand runners, where a release will fail:
The underlying issue is a panic during the init phase caused by something that's only used in development, so here we change that to simply return.
UPDATE: refactored/rebased to completely exclude
internal/assets/dev.go
from builds with theassetsembedded
tag (see the Makefile for reference). Thedev.go
file was generatingdev_assets.go
which was not included in builds, however thedev.go
file itself still was, and it'sinit()
method could cause troubles