Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Backport of Return instead of panic in code that is only used in dev into release/0.6.x #2546

Conversation

hc-github-team-waypoint
Copy link
Collaborator

Backport

This PR is auto-generated from #2533 to be assessed for backporting due to the inclusion of the label backport/0.6.x.

The below text is copied from the body of the original PR.


This bit of code causes an issue in at least AWS ECS server installs using on-demand runners, where a release will fail:

! Unrecognized remote plugin message:
  This usually means that the plugin is either invalid or simply
  needs to be recompiled to support the latest protocol.

The underlying issue is a panic during the init phase caused by something that's only used in development, so here we change that to simply return.

UPDATE: refactored/rebased to completely exclude internal/assets/dev.go from builds with the assetsembedded tag (see the Makefile for reference). The dev.go file was generating dev_assets.go which was not included in builds, however the dev.go file itself still was, and it's init() method could cause troubles

@hc-github-team-waypoint hc-github-team-waypoint force-pushed the backport/dev-asset-fix/trivially-comic-joey branch from 787bad7 to 35c09c0 Compare October 21, 2021 16:37
@hc-github-team-waypoint hc-github-team-waypoint merged commit 5960667 into release/0.6.x Oct 21, 2021
@hc-github-team-waypoint hc-github-team-waypoint deleted the backport/dev-asset-fix/trivially-comic-joey branch October 21, 2021 16:37
@github-actions github-actions bot added the core label Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants