This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Backport of core/app_build: Fix panic where Waypoint plugin missing AccessInfoFunc into release/0.6.x #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-waypoint
force-pushed
the
backport/maint/improve-err-handling-for-plugin-errs/solely-secure-polliwog
branch
from
0201c4a
to
a55858f
Compare
hc-github-team-waypoint
deleted the
backport/maint/improve-err-handling-for-plugin-errs/solely-secure-polliwog
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #2532 to be assessed for backporting due to the inclusion of the label backport/0.6.x.
The below text is copied from the body of the original PR.
This pull request fixes an issue where a compiled Waypoint plugin fails to
register an AccessInfoFunc(). Instead of directly passing nil, causing a
panic during build, we look to see if the function is defined first. If
not, return the proper errors.