This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
ui: add all operation info to OperationStatusIndicator #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabrinako
added
ui
pr/no-changelog
sabrinako
force-pushed
the
ui/operation-status-indicator
branch
from
3b982b3
to
ee94088
Compare
jgwhite
approved these changes
Nov 10, 2021
| @@ -0,0 +1,5 @@ | |||
| <OperationStatusIndicator @operation={{@operation}} @isDetailed={{false}}> | |||
| <:status-text> | |||
| {{if (eq @operation.status.state 1) 'Releasing' 'Released'}} on | |||
There was a problem hiding this comment.
Would be nice if we can localize this. Don’t sweat it if it’s a pain though.
If you’re feeling adventurous, you could try some advanced ICU formatting, though that gets pretty wacky pretty quickly 😅
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Originally, the
OperationStatusIndicatorjust encapsulated the time information related to an operation. This was always paired with the actual operation (ie:Deployed to Docker) which was being hard coded in every instance to account for the slight differences in code between each operation type. This PR combines the operation and the time information inOperationStatusIndicatorand creates child versions for each operation type.Additionally, this PR lays some groundwork for #2681
To Test
git checkout ui/operation-status-indicatoryarn start