This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 327
feature: RunTrigger gRPC endpoint for Waypoint Server #2840
Merged
Merged
Changes from 47 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
d9c7049
Define RunTrigger grpc method
briancain 4892a1c
Initial implementation of RunTrigger service method
briancain cf7ca4e
Add service level tests for runtrigger api func
briancain 2772990
Fix linter for copying msg with locks
briancain d528d90
Add note about exec overrides
briancain eac6554
Ensure workspace is auto-set if not specified on Upsert
briancain 7b9ec2e
Humanize time in trigger list
briancain b63777e
Huamize last active time in inspect cmd
briancain b8fdff9
Only queue multi-job if multi-app trigger run has been requested
briancain a2d30d4
Improve logging in runtrigger service func
briancain 3300551
Label all run trigger jobs with requested trigger ID
briancain 67b61b8
Include variable overrides when requesting run triggers
briancain a6444a4
Add a queue job request func to return requests for all apps in project
briancain 43aad09
Only support cli sourced vars in runtrigger
briancain cdf5920
linter: Copy all relevant template job values into generated job
briancain 5f80348
Allow trigger update to update workspace/project/app target
briancain 910397e
Fixup timestamp usage
briancain feba47c
Use copystructure to copy job template for project scoped job generation
briancain 8bac0e2
Add tests to ensure JobCreate only creates requested job number
briancain e604199
Simplify runtrigger by always using queueJobMulti to start triggers
briancain 52d9118
Fixup warn log
briancain 79e93d5
Add a quick note about queueJobMulti
briancain 367cc81
Add CHANGELOG
briancain 5264f5a
cli: remove word 'operation' from displaying operation
briancain d79b24b
cli: Fix panic where id was provided by flag and not argument
briancain 8d8fbf6
cli: Reduce total columns for listing triggers, introduce full flag f…
briancain 3fef7c0
Include which flag to set for empty operation
briancain 84f9b5a
Remove id flag, only use argument in trigger inspect
briancain 0922086
Update .changelog/2840.txt
briancain 7bf3fb5
Set artifact message for Deployment operations on running triggers
briancain a14fa8c
Add note about deploy op and pushedartifact
briancain 9af0503
More explicit description for operation options in trigger create/update
briancain 6e01c33
Ensure application refs are properly set
briancain db323c0
Update internal/cli/trigger_apply.go
briancain 0cb4f95
Website autogen from cli doc string fix
briancain 7baac59
core: Ensure full Deployment proto message is set for queueing Release
briancain fbead7c
core: Add status report deploy and release operation type triggers
briancain 7014dd4
Server proto auto-gen
briancain 338ca0b
docs: fix typo in code doc
briancain 7d907cb
Add trigger URL docs
briancain e14a219
Update how to run trigger via grpc and explain job id returns
briancain 8197b6c
Add future HTTP section
briancain f17bfe8
Fix typo in trigger docs
briancain 22734d9
Ensure Build proto message is set for Artifact Push operation
briancain 5c3fddd
Ensure Deployment Destroy has a Deployment full proto message set
briancain 5d58f8b
Apply suggestions from code review
briancain 8c8c6e0
Docs fix: We -> You
briancain 3d72cd3
core: Improve error message for variable override wrong type
briancain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
```release-note:feature | ||
core: Introduce RunTriggers to Waypoint Server and CLI. Triggers can be configured | ||
ahead of time to execute lifecycle operations on demand through the Waypoint API. | ||
Currently, only the gRPC API is supported, but in the future an HTTP endpoint | ||
will be added to be used within CI. | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make that flow cleaner, and optionally refactor the triggers below to have the flag check as the first conditional for uniformity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll still have to do this workspace flag check later, because inside this if-statement we're only setting these values if we're updating a trigger URL and one already exists, i.e. the check on line 83. So in the creation case, we'll still need the check below if workspace was not set.