This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Consumable authentication handlers #3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izaaklauer
commented
Mar 31, 2022
| @@ -25,28 +26,25 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| // The username of the initial user created during bootstrapping. This | |||
| // DefaultUser is the username of the initial user created during bootstrapping. This | |||
There was a problem hiding this comment.
Updating comments to godoc style
izaaklauer
added
the
pr/no-changelog
izaaklauer
commented
Mar 31, 2022
Comment on lines
+476
to
+484
| encodedId, err := s.encodeId(ctx, currentUser.Id) | ||
| if err != nil { | ||
| msg := "failed to encode id when generating a login token" | ||
| log.Error(msg, "currentUser.Id", currentUser.Id, "err", err) | ||
| return nil, status.Error(codes.Internal, msg) | ||
| } | ||
|
|
||
| login := &pb.Token_Login{ | ||
| UserId: currentUser.Id, | ||
| UserId: encodedId, |
There was a problem hiding this comment.
I'll note that I don't love this flow. It's not at all intuitive when IDs need to be encoded/decoded, and I don't have any great heuristics to offer. It will be easy for us to implement new logic in the future that skips doing this.
izaaklauer
commented
Mar 31, 2022
| if conf.Cookie == "" { | ||
| err := state.ServerConfigSet(conf) | ||
| if err != nil && status.Convert(err).Code() != codes.Unimplemented { | ||
| if !cfg.skipServerConfigInit { |
There was a problem hiding this comment.
This is a mostly unrelated change - it allows the server to be started without initializing a global cookie.
izaaklauer
changed the title
izaaklauer
force-pushed
the
consumable-service-handlers-2
branch
from
bf32d41
to
8ee8fbf
Compare
izaaklauer
force-pushed
the
consumable-service-handlers-2
branch
from
8ee8fbf
to
678bff8
Compare
Co-authored-by: Shirley Xiaolin Xu <34314221+xiaolin-ninja@users.noreply.github.com>
izaaklauer
force-pushed
the
consumable-service-handlers-2
branch
from
ff7d58c
to
6dfe8e5
Compare
evanphx
approved these changes
Apr 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In much the same vein as #3149, this refactoring allows other waypoint server implementations to consume the authentication logic here. This should not change any behavior or functionality.