This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
builtin/docker: Do not require resources
for task launch config
#3486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the task launcher was expecting
Resources
to bea required plugin config option despite it not actually being required.
This was due to the
TaskResources
field being expected to exist in atask plugin despite being optional. The fix, similar to how we handle
resource plugin configs in kubernetes, is to make the Resources block a
pointer so that when it's unset, the plugin config parser doesn't expect
it to be required.
Fixes #3485