Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Backport of Fix panic when setting odr env vars into release/0.10.x #4040

Conversation

hc-github-team-waypoint
Copy link
Collaborator

Backport

This PR is auto-generated from #3995 to be assessed for backporting due to the inclusion of the label backport/0.10.x.

The below text is copied from the body of the original PR.


Prior to this, assignment to the nil map would panic. E.x:

$ waypoint runner profile set -name=k8s -plugin-type=kubernetes -env-var=container=docker
❌ Updating runner profile "k8s" ("01GEMHHFSA3K6XXQR4Q0FVCKGJ")...
panic: assignment to entry in nil map

goroutine 1 [running]:
github.com/hashicorp/waypoint/internal/cli.(*RunnerProfileSetCommand).Run(0xc000246880, {0xc000311940, 0x6, 0xc})
	/Users/izaaklauer/dev/waypoint/internal/cli/runner_profile_set.go:231 +0x15e5
github.com/mitchellh/cli.(*CLI).Run(0xc00056a280)
	/Users/izaaklauer/go/pkg/mod/github.com/mitchellh/cli@v1.1.2/cli.go:262 +0x5f8
github.com/hashicorp/waypoint/internal/cli.Main({0xc000198000?, 0x3813f60?, 0xc0000021a0?})
	/Users/izaaklauer/dev/waypoint/internal/cli/main.go:127 +0x545
main.main()
	/Users/izaaklauer/dev/waypoint/cmd/waypoint/main.go:14 +0x7f

@hc-github-team-waypoint hc-github-team-waypoint merged commit 565e2d0 into release/0.10.x Oct 12, 2022
@hc-github-team-waypoint hc-github-team-waypoint force-pushed the backport/fix-odr-profile-env-var/readily-evolved-man branch from 9f3b7db to de42bd5 Compare October 12, 2022 17:45
@hc-github-team-waypoint hc-github-team-waypoint deleted the backport/fix-odr-profile-env-var/readily-evolved-man branch October 12, 2022 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant