Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Fix pipeline exec steps run in Nomad #4185

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Fix pipeline exec steps run in Nomad #4185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changelog/4185.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
```release-note:bug
plugin/nomad: Update Nomad task launcher plugin to use `entrypoint` config - fixes
pipeline exec steps run in Nomad.
```
6 changes: 3 additions & 3 deletions builtin/nomad/task.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,9 +263,9 @@ func (p *TaskLauncher) StartTask(

// On-Demand runner specific configuration to start the task with
config := map[string]interface{}{
"image": tli.OciUrl,
"args": tli.Arguments,
"command": tli.Entrypoint,
"image": tli.OciUrl,
"args": tli.Arguments,
"entrypoint": tli.Entrypoint,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, surprised we didn't catch this with other ODR jobs! Do we not need to also set the command for the launched resource too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope! Setting the command in addition to the entrypoint here would just add args to the command that the entrypoint runs.

}

job.TaskGroups[0].Tasks[0].Config = config
Expand Down