Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Fixing panic in ECS runner uninstall when EFS is missing #4829

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Fixing panic in ECS runner uninstall when EFS is missing #4829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4dd181
Do not panic if EFS not found
izaaklauer Jul 5, 2023
dd31fb3
changelog
izaaklauer Jul 5, 2023
91508cb
Update .changelog/4829.txt
izaaklauer Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/4829.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
runneruninstall/aws-ecs: Fix panic when uninstalling ECS runner after failing to find EFS
```
2 changes: 1 addition & 1 deletion internal/runnerinstall/ecs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ func (i *ECSRunnerInstaller) Uninstall(ctx context.Context, opts *InstallOpts) e
}
}

if *fileSystemId == "" {
if fileSystemId == nil || *fileSystemId == "" {
s.Update("File system with tag key `runner-id` and value " + opts.Id + " not detected, skipping deletion")
s.Done()
return nil
Expand Down