-
Notifications
You must be signed in to change notification settings - Fork 329
Conversation
d83bae3
to
19aac83
Compare
We won’t need this once we have `Icon` from cloud-ui
19aac83
to
f5f6abb
Compare
@pearkes Think this is complete for now! The one thing I couldn't get working was redirecting from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I left some notes to follow-up. Putting all the text in translations is the biggest todo here, then maybe refining the hint component(s) a bit.
@@ -0,0 +1,17 @@ | |||
<button class="button button--secondary" {{on "click" this.showHint}}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can make this a generic component. Could use arguments for some of them and named blocks for the longer text ("To deploy this build you can run...").
We'd need to install this polyfill. But I think it might be great for this scenario.
<Login></Login> | ||
<p>Run <code>waypoint token new</code></p> | ||
{{inline-svg "waypoint-logo" class="logo"}} | ||
<h1>Welcome to Waypoint</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do all this text from translations (easier to tackle that now and make it standard.
@tracked hintIsVisible = false; | ||
|
||
@action | ||
showHint() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can make this a toggle so:
toggleHint() {
this.hintIsVisible = !this.hintIsVisible
}
@@ -0,0 +1,17 @@ | |||
<button class="button button--primary" {{on "click" this.showHint}}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we make this toggleHint
it will also close the hint which I think is also assumed by some users (double click to open/close).
Vendor HashiCorp Product Design System as Package
Adds the
pds
theme fromcloud-ui
directly to the project and refactors our existing styling to utilise tokens and styles from there instead of our own.I'll keep working on this branch and hopefully by the time it's ready to merge we can bring in the real thing as a dependency and drop the manual addition here.