Skip to content
This repository was archived by the owner on Jan 8, 2024. It is now read-only.

Utilize cloud-ui theme #92

Merged
merged 25 commits into from
Aug 21, 2020
Merged

Utilize cloud-ui theme #92

merged 25 commits into from
Aug 21, 2020

Conversation

dizzyup
Copy link
Contributor

@dizzyup dizzyup commented Aug 11, 2020

Adds the pds theme from cloud-ui directly to the project and refactors our existing styling to utilise tokens and styles from there instead of our own.

I'll keep working on this branch and hopefully by the time it's ready to merge we can bring in the real thing as a dependency and drop the manual addition here.

@dizzyup dizzyup requested a review from pearkes August 11, 2020 15:40
@dizzyup dizzyup self-assigned this Aug 11, 2020
@pearkes pearkes force-pushed the add-cloud-ui-scss branch from d83bae3 to 19aac83 Compare August 14, 2020 20:03
@dizzyup dizzyup force-pushed the add-cloud-ui-scss branch from 19aac83 to f5f6abb Compare August 18, 2020 12:43
@dizzyup dizzyup marked this pull request as ready for review August 18, 2020 16:21
@dizzyup
Copy link
Contributor Author

dizzyup commented Aug 21, 2020

@pearkes Think this is complete for now!

The one thing I couldn't get working was redirecting from the workspaces route to the workspace route - any chance you could tag on a commit to do that??

Copy link
Contributor

@pearkes pearkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I left some notes to follow-up. Putting all the text in translations is the biggest todo here, then maybe refining the hint component(s) a bit.

@@ -0,0 +1,17 @@
<button class="button button--secondary" {{on "click" this.showHint}}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can make this a generic component. Could use arguments for some of them and named blocks for the longer text ("To deploy this build you can run...").

We'd need to install this polyfill. But I think it might be great for this scenario.

<Login></Login>
<p>Run <code>waypoint token new</code></p>
{{inline-svg "waypoint-logo" class="logo"}}
<h1>Welcome to Waypoint</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do all this text from translations (easier to tackle that now and make it standard.

@tracked hintIsVisible = false;

@action
showHint() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can make this a toggle so:

toggleHint() {
     this.hintIsVisible = !this.hintIsVisible
}

@@ -0,0 +1,17 @@
<button class="button button--primary" {{on "click" this.showHint}}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we make this toggleHint it will also close the hint which I think is also assumed by some users (double click to open/close).

@pearkes pearkes merged commit 1ca798b into master Aug 21, 2020
@pearkes pearkes deleted the add-cloud-ui-scss branch August 21, 2020 19:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants