This repository was archived by the owner on Jan 8, 2024. It is now read-only.
Vendor cloud packages #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We won’t need this once we have `Icon` from cloud-ui
dizzyup
reviewed
Aug 12, 2020
There was a problem hiding this comment.
It looks as though we need to compile and link up the styles from cloud-ui but I'm not sure how we go about that. The components are working and render their correct output, but there are no styles associated with the class names which is why <Detail::Card> ends up with no styles.
There's a separate issue I'm running into when trying to render icons natively with the <Icon /> component where again, the markup is being rendered, but the icon SVG itself doesn't get rendered. I assume there's a link between <Icon /> and the @hashicorp/structure-icons package that isn't working.
|
@dizzyup ah sorry I missed that. Looking into that now. |
pearkes
force-pushed
the
add-cloud-ui-scss
branch
from
d83bae3 to
19aac83
Compare
dizzyup
force-pushed
the
add-cloud-ui-scss
branch
from
19aac83 to
f5f6abb
Compare
|
Closing in favor of the approach in #111. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This vendors the PDS addon and cloud-ui-core addon for use. Eventually these will be npm packages we can import in the same way but not need to vendor.
Unfortunately swapping to this other Card implementation and some imports broke some minor things but I believe that will be easily fixable.