Skip to content

CE-915 - Consul TLS with vault #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

CE-915 - Consul TLS with vault #1359

wants to merge 10 commits into from

Conversation

@danielehc
Copy link
Contributor

@danielehc danielehc commented Nov 20, 2025 •
edited by atlassian bot
Loading

Description

Links

Jira: CE-915

Contributor checklists

Review urgency:

  • ASAP: Bug fixes, broken content, imminent releases
  • 3 days: Small changes, easy reviews
  • 1 week: Default expectation
  • Best effort: No urgency

Pull request:

  • Verify that the PR is set to merge into the correct base branch
  • Verify that all status checks passed
  • Verify that the preview environment deployed successfully
  • Add additional reviewers if they are not part of assigned groups

Content:

  • I added redirects for any moved or removed pages
  • I followed the Education style guide
  • I looked at the local or Vercel build to make sure the content rendered correctly

Reviewer checklist

  • This PR is set to merge into the correct base branch.
  • The content does not contain technical inaccuracies.
  • The content follows the Education content and style guides.
  • I have verified and tested changes to instructions for end users.

@danielehc danielehc self-assigned this Nov 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025 •
edited
Loading

Vercel Previews Deployed

Name Status Preview Updated (UTC)
Dev Portal ✅ Ready (Inspect) Visit Preview Thu Nov 27 17:43:34 UTC 2025
Unified Docs API ✅ Ready (Inspect) Visit Preview Thu Nov 27 17:36:55 UTC 2025

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025 •
edited
Loading

Broken Link Checker

No broken links found! 🎉

boruszak
boruszak reviewed Nov 25, 2025
View reviewed changes
Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions for style guide/english language clarity.

danielehc and others added 3 commits November 26, 2025 16:37
@danielehc @boruszak
Update content/consul/v1.22.x/content/docs/automate/consul-template/v…
ef9ec9e 
…ault/mtls.mdx

Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
@danielehc @boruszak
Apply suggestions from code review
1ec6ae6 
Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
@danielehc
Merge branch 'main' into dc-consul-CE-915
eff70b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boruszak boruszak boruszak left review comments

@krastin krastin Awaiting requested review from krastin

At least 1 approving review is required to merge this pull request.

Assignees

@danielehc danielehc

Labels

Consul

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielehc @boruszak