Support shrinking of receive buffers of a stream #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2015
| if s.recvBuf == nil { | ||
| // Allocate the receive buffer just-in-time to fit the full data frame. | ||
| // This way we can read in the whole packet without further allocations. | ||
| s.recvBuf = bytes.NewBuffer(make([]byte, 0, length)) |
There was a problem hiding this comment.
Interesting that Go has a hard-coded 32k here the way we were doing it before.
|
LGTM |
armon
added a commit
that referenced
this pull request
Nov 29, 2015
Support shrinking of receive buffers of a stream
|
@armon wonder if pool size + time based auto-shrink would be a good idea if len(streams) > k && (now - s.lastRecvd) > timeout {
s.Shrink()
} |
|
@jbenet it's hard to do automatically at the yamux layer as we have no context from the application. We've used this in the Consul and Nomad connection pools however where we do have more context! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
Shrinkmethod that allows the receive buffers of a Stream to be truncated to zero. This can be useful when connection pooling may keep idle Streams around, as they may have grown their internal buffers to be fairly large (256KB max by default)./cc: @slackpad