Fix the ping test by adding a delay to the write operation #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TestPing
unit test failed on my machine since it always reported a rtt of 0. I guess that is since the Go timers are not very accurate on windows and writing through pipes is really fast.I fixed that now by introducing a delay/sleep to the write.
It's a little hacky since I grab and modify the connection from the session which would be unsafe if it sends anything while not externally called. But I think it doesn't do that as long as there are not streams, pings or keepalives running and works for that test.
The other alternative is to introduce a general delay option to pipeConn which I did first. But there unit tests need to be modified in lots of places to set that new parameter.