Restrict pending the spec to only Ruby versions 2.2.0, 2.2.1, 2.2.2 #313

pboling · 2015-10-18T19:12:45Z

Fixes #312

Restrict pending the spec to only Ruby versions 2.2.0, 2.2.1, 2.2.2
Better paradigm for pending specs due to bugs in interpreter
- new gem rspec-pending_for, written by yours truly.
- Gem is based on ruby_version and ruby_engine gems. Just using them directly did not actually reduce the complexity much.

dblock · 2015-10-19T01:35:15Z

spec/support/ruby_version.rb

+# For things Broken in Ruby <= 2.2.2, Fixed in 2.2.3+
+def pending_for_mri220_to_mri222
+  version = ruby_version
+  return unless version.start_with?('ruby_2.2') && version.end_with?('0', '1', '2')


There's a finate list of these, can we just check for something like ['ruby_2.2....].include?.

Yep. Changing.

pboling · 2015-10-19T04:36:21Z

spec/hashie/mash_spec.rb

-      if mri22?
-        pending 'Bug in MRI 2.2.x means this behavior is broken in those versions'
-      end
+      pending_for(engine: 'ruby', versions: %w(2.2.0 2.2.1 2.2.2))


@dblock How do you like me now. 😸

pboling · 2015-10-19T04:41:32Z

@dblock this is ready, and output, running specs on Ruby 2.2.2 looks like:

Pending:
  Hashie::Mash#respond_to? is able to access an unknown suffixed key as a method
    # This behavior is broken in Ruby versions ["2.2.0", "2.2.1", "2.2.2"] due to a bug in the Ruby engine (MRI >= 1.9 or REE)
    # ./spec/hashie/mash_spec.rb:365

Finished in 0.13778 seconds (files took 0.41187 seconds to load)
560 examples, 0 failures, 1 pending

- Better paradigm for pending specs due to bugs in interpreter

dblock · 2015-10-19T11:07:38Z

It's an amazing effort. However am I wrong that most of this is implemented in https://github.com/janlelis/ruby_version or https://github.com/martinkozak/ruby-version?

RubyVersion.between? '2.2.0', '2.2.2'

michaelherold · 2015-10-19T15:39:29Z

You're right about that, dB. I made the conscious decision not to pull in one of those back when I added the simple check.

If we need the more complicated logic, it might make sense to pull one of them in.

dblock · 2015-10-19T16:00:26Z

Well what's here is more complicated logic. This entire thing should be a 1-liner, but it should be robust, Hashie is not in the business of parsing ruby versions. Would you like to try with one of those gems?

dblock · 2015-10-19T16:00:36Z

And sorry to be a pest ;)

pboling · 2015-10-19T17:45:57Z

I'll switch to a maintained gem. My StrictKeyAccess / Dictionary PR has some specs that are pended for Rubinius, and utilized this complication.

dblock · 2015-10-19T17:50:54Z

Thanks @pboling - hang in there! Lets get this PR done first. Add a note when you amended it.

pboling · 2015-10-19T20:16:50Z

@dblock Having reviewed the options I propose we use:

Because they appear maintained, and the syntax is good.

dblock · 2015-10-19T20:59:12Z

I don't care which gem personally as long as we have something like a 1-liner in hashie ;)

- a one liner with no complexity for pending specs by Ruby Engine / Version - removes all complexity from Hashie

pboling · 2015-10-22T09:08:40Z

@dblock I used those two gems, but the complexity remained in Hashie, so I rolled it out into a separate gem, as it seems like a common, generic, basic need of many projects, that I think I will want to use... everywhere.

https://github.com/pboling/rspec-pending_for

pboling · 2015-10-22T09:10:44Z

If this is acceptable, then I will rebase and squash commits. Let me know.

dblock · 2015-10-22T10:58:22Z

👍 on rspec-pending-for !

…d-mash-spec Restrict pending the spec to only Ruby versions 2.2.0, 2.2.1, 2.2.2

dblock · 2015-10-22T10:58:55Z

Awesome, merged.

@pboling

## 3.4.3 (10/25/2015) * [#314](hashie/hashie#314): Added a `StrictKeyAccess` extension that will raise an error whenever a key is accessed that does not exist in the hash - [@pboling](https://github.com/pboling). * [#304](hashie/hashie#304): Ensured compatibility of `Hash` extensions with singleton objects - [@regexident](https://github.com/regexident). * [#306](hashie/hashie#306): Added `Hashie::Extensions::Dash::Coercion` - [@marshall-lee](https://github.com/marshall-lee). * [#310](hashie/hashie#310): Fixed `Hashie::Extensions::SafeAssignment` bug with private methods - [@marshall-lee](https://github.com/marshall-lee). * [#313](hashie/hashie#313): Restrict pending spec to only Ruby versions 2.2.0-2.2.2 - [@pboling](https://github.com/pboling). * [#315](hashie/hashie#315): Default `bin/` scripts: `console` and `setup` - [@pboling](https://github.com/pboling).

pboling force-pushed the issue/312-ruby-2.2.3-fixes-pended-mash-spec branch from e822f48 to 3cc9955 Compare October 18, 2015 19:18

pboling mentioned this pull request Oct 18, 2015

Ruby 2.2.3 is out and fixes a bug with Hashie #316

Closed

3 tasks

dblock reviewed Oct 19, 2015
View reviewed changes

pboling force-pushed the issue/312-ruby-2.2.3-fixes-pended-mash-spec branch from 3cc9955 to 52476cb Compare October 19, 2015 04:35

pboling reviewed Oct 19, 2015
View reviewed changes

pboling force-pushed the issue/312-ruby-2.2.3-fixes-pended-mash-spec branch from 52476cb to e79659e Compare October 19, 2015 04:40

pboling force-pushed the issue/312-ruby-2.2.3-fixes-pended-mash-spec branch from 453101c to feb9472 Compare October 19, 2015 05:00

- Restrict pending the spec to only Ruby versions 2.2.0, 2.2.1, 2.2.2

a44dd9a

- Better paradigm for pending specs due to bugs in interpreter

pboling force-pushed the issue/312-ruby-2.2.3-fixes-pended-mash-spec branch from feb9472 to a44dd9a Compare October 19, 2015 05:16

pboling mentioned this pull request Oct 19, 2015

StrictKeyAccess Extension #314

Merged

1 task

@dblock

43d86f1

- a one liner with no complexity for pending specs by Ruby Engine / Version - removes all complexity from Hashie

dblock added a commit that referenced this pull request Oct 22, 2015

Merge pull request #313 from pboling/issue/312-ruby-2.2.3-fixes-pende…

5c276eb

…d-mash-spec Restrict pending the spec to only Ruby versions 2.2.0, 2.2.1, 2.2.2

dblock merged commit 5c276eb into hashie:master Oct 22, 2015

michaelherold mentioned this pull request Oct 23, 2015

Tracking Ruby 2.2 bug that needs backported #285

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Restrict pending the spec to only Ruby versions 2.2.0, 2.2.1, 2.2.2 #313

Restrict pending the spec to only Ruby versions 2.2.0, 2.2.1, 2.2.2 #313

pboling commented Oct 18, 2015

dblock Oct 19, 2015

pboling Oct 19, 2015

pboling Oct 19, 2015

pboling commented Oct 19, 2015

dblock commented Oct 19, 2015

michaelherold commented Oct 19, 2015

dblock commented Oct 19, 2015

dblock commented Oct 19, 2015

pboling commented Oct 19, 2015

dblock commented Oct 19, 2015

pboling commented Oct 19, 2015

dblock commented Oct 19, 2015

pboling commented Oct 22, 2015

pboling commented Oct 22, 2015

dblock commented Oct 22, 2015

dblock commented Oct 22, 2015

Restrict pending the spec to only Ruby versions 2.2.0, 2.2.1, 2.2.2 #313

Restrict pending the spec to only Ruby versions 2.2.0, 2.2.1, 2.2.2 #313

Conversation

pboling commented Oct 18, 2015

dblock Oct 19, 2015

Choose a reason for hiding this comment

pboling Oct 19, 2015

Choose a reason for hiding this comment

pboling Oct 19, 2015

Choose a reason for hiding this comment

pboling commented Oct 19, 2015

dblock commented Oct 19, 2015

michaelherold commented Oct 19, 2015

dblock commented Oct 19, 2015

dblock commented Oct 19, 2015

pboling commented Oct 19, 2015

dblock commented Oct 19, 2015

pboling commented Oct 19, 2015

dblock commented Oct 19, 2015

pboling commented Oct 22, 2015

pboling commented Oct 22, 2015

dblock commented Oct 22, 2015

dblock commented Oct 22, 2015