Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deer: implement Deserialize for core::marker #2379

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Conversation

indietyp
Copy link
Member

@indietyp indietyp commented Apr 9, 2023

🌟 What is the purpose of this PR?

Implements Deserialize for:

  • core::marker::PhantomData

Does not implement Deserialize for core::marker::PhantomPinned, reason being that PhantomPinned is only really used for types that implement Future, those are unlikely to be deserialized (also serde does not implement it)

Taken from #1875 in an effort to make PRs smaller

🔗 Related links

🔍 Has this modified a publishable library?

This PR:

  • modifies an npm-publishable library and I have added a changeset file(s)
  • modifies a Cargo-publishable library and I have amended the version
  • modifies a Cargo-publishable library, but it is not yet ready to publish
  • modifies a block that will need publishing via GitHub action once merged
  • does not modify any publishable blocks or libraries
  • I am unsure / need advice

@indietyp indietyp requested a review from a team as a code owner April 9, 2023 17:00
@github-actions github-actions bot added the area/libs > deer Affects the `deer` crate (library) label Apr 9, 2023
@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Attention: Patch coverage is 38.88889% with 11 lines in your changes missing coverage. Please review.

Project coverage is 60.68%. Comparing base (7633fdd) to head (ea7d81c).
Report is 3046 commits behind head on main.

Files with missing lines Patch % Lines
libs/deer/src/impls/core/marker.rs 38.88% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2379      +/-   ##
==========================================
- Coverage   60.69%   60.68%   -0.02%     
==========================================
  Files         317      318       +1     
  Lines       24279    24297      +18     
  Branches      421      421              
==========================================
+ Hits        14737    14744       +7     
- Misses       9537     9548      +11     
  Partials        5        5              
Flag Coverage Δ
backend-integration-tests 3.66% <ø> (ø)
deer 69.09% <38.88%> (-0.15%) ⬇️
unit-tests 1.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

TimDiekmann
TimDiekmann previously approved these changes Apr 12, 2023
@indietyp indietyp added this pull request to the merge queue Apr 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 13, 2023
@indietyp indietyp requested a review from TimDiekmann April 13, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/libs > deer Affects the `deer` crate (library)
Development

Successfully merging this pull request may close these issues.

2 participants