-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deer
: implement Deserialize
for core::sync
#2386
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2386 +/- ##
=======================================
Coverage 56.76% 56.77%
=======================================
Files 336 337 +1
Lines 26012 26015 +3
Branches 421 421
=======================================
+ Hits 14766 14769 +3
Misses 11241 11241
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
TimDiekmann
previously approved these changes
Apr 12, 2023
TimDiekmann
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
Implements
Deserialize
for:core::sync::Exclusive
(nightly only, taken fromdeer
implementDeserialize
for built-in types (Part 2) #1875)atomic.rs
intocore/sync/atomic.rs
to mirrorcore::sync::atomic
structureBased upon #2376, the new low-level assertion function is needed because
PartialEq
is not implemented onExclusive
.🔗 Related links
deer
type implementation #1700deer
implementDeserialize
for built-in types (Part 2) #1875🔍 Has this modified a publishable library?
This PR: