-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deer
: implement Deserialize
for core::ops
#2422
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2422 +/- ##
==========================================
+ Coverage 52.63% 52.75% +0.11%
==========================================
Files 328 331 +3
Lines 27245 27558 +313
Branches 421 421
==========================================
+ Hits 14341 14538 +197
- Misses 12902 13018 +116
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I have a couple comments :)
🌟 What is the purpose of this PR?
implement
Deserialize
for:core::ops::Bound
core::ops::Range
core::ops::RangeInclusive
core::ops::RangeFull
(?)core::ops::RangeTo
(?)core::ops::RangeToInclusive
(?)core::ops::RangeFrom
(?)Things marked (?) will be implemented once a decision is on Slack thread (internal) has been made.
Things marked with (?) are not implemented in
serde
right now, but I think they are still valuable to the API.🚫 Blocked By
deer
: introduceStructVisitor
#2437deer
: introduceIdentifierVisitor
#2513🔗 Related links
deer
type implementation #1700deer
implementDeserialize
for built-in types (Part 2) #1875🚀 Has this modified a publishable library?
This PR: