Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deer: implement Deserialize for core::ops #2422

Merged
merged 22 commits into from
Jun 7, 2023
Merged

deer: implement Deserialize for core::ops #2422

merged 22 commits into from
Jun 7, 2023

Conversation

indietyp
Copy link
Member

@indietyp indietyp commented Apr 14, 2023

🌟 What is the purpose of this PR?

implement Deserialize for:

  • core::ops::Bound
  • core::ops::Range
  • core::ops::RangeInclusive
  • core::ops::RangeFull (?)
  • core::ops::RangeTo (?)
  • core::ops::RangeToInclusive (?)
  • core::ops::RangeFrom (?)

Things marked (?) will be implemented once a decision is on Slack thread (internal) has been made.

Things marked with (?) are not implemented in serde right now, but I think they are still valuable to the API.

This is the last PR that implements core, once done we can move onto alloc 🎉

🚫 Blocked By

🔗 Related links

🚀 Has this modified a publishable library?

This PR:

  • modifies an npm-publishable library and I have added a changeset file(s)
  • modifies a Cargo-publishable library and I have amended the version
  • modifies a Cargo-publishable library, but it is not yet ready to publish
  • modifies a block that will need publishing via GitHub action once merged
  • does not modify any publishable blocks or libraries, or modifications do not need publishing
  • I am unsure / need advice

@github-actions github-actions bot added the area/libs > deer Affects the `deer` crate (library) label Apr 14, 2023
@indietyp indietyp changed the title feat: init deer: implement Deserialize for core::ops Apr 14, 2023
libs/deer/src/impls/core/ops.rs Fixed Show fixed Hide fixed
libs/deer/src/impls/core/ops.rs Fixed Show fixed Hide fixed
libs/deer/src/impls/core/ops.rs Fixed Show fixed Hide fixed
libs/deer/src/impls/core/ops.rs Fixed Show fixed Hide fixed
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #2422 (eecc5d5) into main (3ed367d) will increase coverage by 0.11%.
The diff coverage is 61.58%.

@@            Coverage Diff             @@
##             main    #2422      +/-   ##
==========================================
+ Coverage   52.63%   52.75%   +0.11%     
==========================================
  Files         328      331       +3     
  Lines       27245    27558     +313     
  Branches      421      421              
==========================================
+ Hits        14341    14538     +197     
- Misses      12902    13018     +116     
  Partials        2        2              
Flag Coverage Δ
deer 65.83% <61.58%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/deer/src/error.rs 49.68% <0.00%> (-2.32%) ⬇️
libs/deer/src/error/duplicate.rs 0.00% <0.00%> (ø)
libs/deer/src/helpers.rs 80.59% <0.00%> (-12.51%) ⬇️
libs/deer/src/lib.rs 72.83% <ø> (ø)
libs/deer/src/macros.rs 84.31% <0.00%> (ø)
libs/deer/src/impls.rs 60.00% <60.00%> (ø)
libs/deer/src/impls/core/ops.rs 77.50% <77.50%> (ø)
libs/deer/src/impls/core/option.rs 66.66% <100.00%> (+1.14%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

libs/deer/src/impls/core/ops.rs Fixed Show fixed Hide fixed
libs/deer/src/impls/core/ops.rs Fixed Show fixed Hide fixed
libs/deer/src/impls/core/ops.rs Fixed Show fixed Hide fixed
libs/deer/src/impls/core/ops.rs Fixed Show fixed Hide fixed
@indietyp indietyp marked this pull request as ready for review June 6, 2023 16:31
@indietyp indietyp requested a review from a team as a code owner June 6, 2023 16:31
@indietyp indietyp removed the state/blocked This pull request is currently blocked label Jun 6, 2023
Copy link
Contributor

@thehabbos007 thehabbos007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have a couple comments :)

libs/deer/src/error/duplicate.rs Show resolved Hide resolved
libs/deer/src/impls/core/ops.rs Outdated Show resolved Hide resolved
libs/deer/src/impls/core/ops.rs Outdated Show resolved Hide resolved
@indietyp indietyp requested a review from thehabbos007 June 7, 2023 14:59
thehabbos007
thehabbos007 previously approved these changes Jun 7, 2023
@indietyp indietyp added this pull request to the merge queue Jun 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/libs > deer Affects the `deer` crate (library)
Development

Successfully merging this pull request may close these issues.

3 participants