Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deer: add *Access::context() #2443

Merged
merged 2 commits into from
Apr 19, 2023
Merged

deer: add *Access::context() #2443

merged 2 commits into from
Apr 19, 2023

Conversation

indietyp
Copy link
Member

🌟 What is the purpose of this PR?

This PR adds ArrayAccess::context() and ObjectAccess::context() which roughly are equivalent to DeserializeSeed in serde. This enables inner methods of ArrayAccess and ObjectAccess to modify/access the context, but also call other deserializers (like NoneDeserializer)

🔗 Related links

🚀 Has this modified a publishable library?

This PR:

  • modifies an npm-publishable library and I have added a changeset file(s)
  • modifies a Cargo-publishable library and I have amended the version
  • modifies a Cargo-publishable library, but it is not yet ready to publish
  • modifies a block that will need publishing via GitHub action once merged
  • does not modify any publishable blocks or libraries, or modifications do not need publishing
  • I am unsure / need advice

@indietyp indietyp requested a review from a team as a code owner April 18, 2023 17:02
@github-actions github-actions bot added the area/libs > deer Affects the `deer` crate (library) label Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 56.38%. Comparing base (fa4ff75) to head (332c7da).
Report is 3021 commits behind head on main.

Files with missing lines Patch % Lines
libs/deer/json/src/lib.rs 0.00% 6 Missing ⚠️
libs/deer/desert/src/array.rs 0.00% 3 Missing ⚠️
libs/deer/desert/src/object.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2443      +/-   ##
==========================================
- Coverage   56.41%   56.38%   -0.03%     
==========================================
  Files         341      341              
  Lines       26287    26299      +12     
  Branches      421      421              
==========================================
  Hits        14829    14829              
- Misses      11453    11465      +12     
  Partials        5        5              
Flag Coverage Δ
backend-integration-tests 3.66% <ø> (ø)
deer 68.71% <0.00%> (-0.22%) ⬇️
unit-tests 1.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@indietyp indietyp added this pull request to the merge queue Apr 19, 2023
Merged via the queue into main with commit 30c9d06 Apr 19, 2023
@indietyp indietyp deleted the bm/deer/access-context branch April 19, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/libs > deer Affects the `deer` crate (library)
Development

Successfully merging this pull request may close these issues.

2 participants