Uncover and Fix Cyclic Dependency, Version-Control Vercel Configs, Fix Turbo Graph. #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/apps > hash*
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2502 +/- ##
==========================================
- Coverage 56.29% 56.08% -0.21%
==========================================
Files 340 330 -10
Lines 26380 26624 +244
Branches 384 425 +41
==========================================
+ Hits 14850 14933 +83
- Misses 11529 11686 +157
- Partials 1 5 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| - [ ] modifies a **block** that will need publishing via GitHub action once merged | ||
| - [ ] does not modify any publishable blocks or libraries, or modifications do not need publishing | ||
| - [ ] I am unsure / need advice | ||
| - [ ] **⚠️ This is a placeholder, please uncomment at least one of the lines following this one and then delete this. ⚠️** |
There was a problem hiding this comment.
I opted for this pattern to try and solve your personal bugbear, @CiaranMn, about the number of "incomplete tasks" that appear for given PRs. This way we should be able to make sure that every checkbox has been checked
There was a problem hiding this comment.
Before
After
There was a problem hiding this comment.
omg yes, this was bothering me so much
apps/hash-frontend/vercel-install.sh
Outdated
Comment on lines
1
to
24
| #!/usr/bin/env bash | ||
|
|
||
| # Setup TurboRepo and get a pruned src folder and lockfile | ||
|
|
||
| echo "Installing turbo" | ||
| yarn global add turbo | ||
|
|
||
| # TODO: investigate why producing a pruned repo results in a broken Vercel build | ||
|
|
||
| #echo "Producing pruned repo" | ||
| #turbo prune --scope='@apps/hash-frontend' | ||
| # | ||
| #echo "Deleting contents of non-pruned dir to save space" | ||
| #git ls-files -z | xargs -0 rm -f | ||
| #git ls-tree --name-only -d -r -z HEAD | sort -rz | xargs -0 rm -rf | ||
| # | ||
| #echo "Moving pruned repo back to root" | ||
| #mv out/* . | ||
| #rm out -r | ||
|
|
||
| # Install the pruned dependencies | ||
|
|
||
| echo "Installing yarn dependencies" | ||
| HUSKY=0 yarn install --frozen-lockfile --prefer-offline --force --build-from-source |
There was a problem hiding this comment.
The use for these files becomes a lot more apparent in #2493
Alfred-Mountfield
force-pushed
the
am/build-improvements
branch
2 times, most recently
from
db17779 to
e000177
Compare
Alfred-Mountfield
force-pushed
the
am/build-improvements
branch
from
7829450 to
aab103f
Compare
Alfred-Mountfield
force-pushed
the
am/build-improvements
branch
from
aab103f to
14d4583
Compare
Alfred-Mountfield
force-pushed
the
am/build-improvements
branch
from
14d4583 to
ba31172
Compare
8 tasks
CiaranMn
previously approved these changes
Apr 28, 2023
Co-authored-by: Ahmad Sattar <thehabbos007@gmail.com>
thehabbos007
approved these changes
Apr 28, 2023
vilkinsons
added
type/eng > frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
This fixes a number of issues uncovered within the repository while trying to get #2493 in.
There was a cyclic dependency between packages that share GraphQL types (
@apps/hash-api,@local/hash-graphql-shared, etc.). This was largely hidden because they were within GraphQL configs, and relied on the file-system, which meant that the dependencies were not within thepackage.jsonand not visible to turborepo.turbo pruneThe configuration for our Vercel deployments was managed purely through Vercel's UI. This means that the configuration (such as build commands) was not version-controlled, and importantly it is shared between all new deployments. Thus, if a PR requires a change to the configuration, that change will break all other in-flight PRs.
vercel.jsonin the individual projects. Thisvercel.jsonworks because the root directory is set within the project configurationhash-frontend, additional shell scripts have been added in preparation of requiring some more complicated setup, including installing Python on the Vercel machine.Requirements were missing from the README such as
PythonandJavaThe changes introduced in Introduce the block design system #2362 accidentally missed some required updates to the Turbo graph. These have been fixed in this PR, and:
The Pull Request template has been updated (to this one) to result in an updated checklist of things to look at pre-merge, which now includes a section on Turborepo.
🔗 Related links
🚫 Blocked by
N/A
🔍 What does this change?
Please see commits.
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
turbo.json's have been updated to reflect this.packfiles that persist across runs instead of being overridden. This means we can have well over 8GB of disk being used up which results in failed deployments. This can be mitigated by manually redeploying the Vercel deployment through the UI and choosing not to re-use the cache. - Slack Thread (internal)turbo prunewithin the Vercel build results in an internal server error. This is probably due to us deleting some of Vercel's files that they are putting in the same root directory as the source code. The attempt at using git to remove only git tracked files did not seem to work.🐾 Next steps
turbo prunedoes not work for Vercel🛡 What tests cover this?
❓ How to test this?
📹 Demo
This PR