Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating dependencies to support NodeJS 18 out-of-the-box #428

Merged
merged 1 commit into from
Dec 3, 2022

Conversation

liarco
Copy link
Member

@liarco liarco commented Dec 3, 2022

No description provided.

@liarco liarco merged commit bad31bc into main Dec 3, 2022
@liarco liarco deleted the upgrading-dependencies branch December 3, 2022 18:58
@sal-420
Copy link

sal-420 commented Dec 4, 2022

@liarco I'm hoping you can provide some insight

  1. the change set displays the differences are to the contract yarn.lock and dapp yarn.lock. Both seem to have many package upgrades.
  2. is it possible that there are no script or coding differences
  3. how can a forked version apply the same change set

@liarco
Copy link
Member Author

liarco commented Dec 4, 2022

Hi @sal-420, this was simply a maintenance release so no changes have been made to the project code.

  1. I updated the dependencies and tested the code to make sure everything was still working as expected (couldn't spot any issues). By upgrading hardhat to the latest version we gained support to Node 18 (previous HH version was complaining about compatibility issues with Node 18 and people were getting stuck when following the tutorials). I also decided to stick to version 3.x for ERC721A to avoid any conflicts on the current stable version of this project, the next major version will probably use 4.x
  2. That's correct, no changes have been made to the code
  3. This depends on what has been done on the fork, if you didn't install any additional dependencies, then you can simply bring the same changes to your fork and it's gonna work fine. If you changed your dependencies (added/removed packages), then it really depends on your specific case and you should manage your dependencies manually (both the original and custom ones)

datboi-1337 added a commit to datboi-1337/nft-erc721-collection that referenced this pull request Jan 16, 2023
Updating dependencies to support NodeJS 18 out-of-the-box (hashlips-lab#428)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants