Change the trait bound for Queue elements from Copy to Unpin #33
+34
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neo-Zhixing
force-pushed
the
queue-unpin
branch
from
0728abf to
26661a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now Queue requires that all elements needs to be
Copy. This seems correct, becausexQueueSendwill copy a predetermined bytes from*pvItemToQueueto the queue.However, let's consider a type that is not
Copy.Veccan be cheaply moved because it only contains ptr, capacity and length, but it is notCopy.I believe that here we only need to require the item to be
Unpinto guarantee that they can be freely moved.