Document how we obtain the name of the cabal config file. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasabel
added a commit
to haskell/cabal
that referenced
this pull request
Jan 13, 2024
Ensure that the last line of the help text is the name of the config file. This invariant is used by clients such as the Haskell setup github action. See: haskell-actions/setup#63
Mikolaj
pushed a commit
to haskell/cabal
that referenced
this pull request
Jan 17, 2024
Ensure that the last line of the help text is the name of the config file. This invariant is used by clients such as the Haskell setup github action. See: haskell-actions/setup#63
andreasabel
force-pushed
the
doc-cabal-config-file
branch
from
fcc14da to
60757a8
Compare
|
See:
The last line of the help text is not the config file, if it does not exist, but rather:
We should make the extraction of the cabal config file more robust. |
erikd
pushed a commit
to erikd/cabal
that referenced
this pull request
Apr 22, 2024
Ensure that the last line of the help text is the name of the config file. This invariant is used by clients such as the Haskell setup github action. See: haskell-actions/setup#63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a comment how we compute the name of the cabal configuration file from the output of
cabal --help.Inherently brittle, so we ensure its correctness upstream:
--helpis the name of the config file haskell/cabal#9614