Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move orphan instances to a separate package #18

Closed
sol opened this issue Apr 12, 2015 · 9 comments
Closed

Move orphan instances to a separate package #18

sol opened this issue Apr 12, 2015 · 9 comments

Comments

@sol
Copy link
Member

sol commented Apr 12, 2015

No description provided.

@RyanGlScott
Copy link
Member

If you create the sol/base-orphans repo, I'd be willing to port over the existing orphan instances from base-compat.

@sol
Copy link
Member Author

sol commented Apr 15, 2015

Hey, sorry to be slow on this. I'll do it tomorrow. Alternatively, if you want to have it under your account I'm fine with that too.

Sent from my iPhone

On 16 Apr 2015, at 1:06 am, Ryan Scott notifications@github.com wrote:

If you create the sol/base-orphans repo, I'd be willing to port over the existing orphan instances in base-compat.


Reply to this email directly or view it on GitHub.

@RyanGlScott
Copy link
Member

We do have quite a collection of compatibility packages now (base-compat, base-orphans, setenv, my mtl-compat package, etc.). Mind if I create a GitHub group (e.g., haskell-compat) and eventually move all of these repos there?

@sol
Copy link
Member Author

sol commented Apr 15, 2015

Sounds good!

Sent from my iPhone

On 16 Apr 2015, at 1:47 am, Ryan Scott notifications@github.com wrote:

We do have quite a collection of compatibility packages now (base-compat, base-orphans, setenv, my mtl-compat package, etc.). Mind if I create a GitHub group (e.g., haskell-compat) and eventually move all of these repos there?


Reply to this email directly or view it on GitHub.

@RyanGlScott
Copy link
Member

I did a quick port of the orphan instances in this repo to base-orphans. Can you review it when you get a chance? One thing I'm a bit indecisive about is the name of the exported module (I dubbed it BaseOrphans for now).

@sol
Copy link
Member Author

sol commented Apr 19, 2015

Yes, I was puzzled about that, too. I had Data.Orphans in mind.

@RyanGlScott
Copy link
Member

I guess if we had to classify under which top-level module name in base the notion of orphan instances would fall under, Data probably makes the most sense. I'll change it as a part of a pull request I'm working on.

@sol
Copy link
Member Author

sol commented Apr 21, 2015

@RyanGlScott I'll remove the orphans from base-compat now, or are you already on it?

@RyanGlScott
Copy link
Member

I'm a bit busy at the moment, so go ahead.

sol added a commit that referenced this issue Apr 21, 2015
@sol sol closed this as completed in 0090a6b Apr 22, 2015
phadej pushed a commit to phadej/base-compat that referenced this issue Dec 11, 2019
…but-orphans-aint-one

Backport Generic instances, Trustworthiness, deriving Foldable/Traversable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants