Allow a client to explicitly terminate the server #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To implement OutputEvents we may need to capture the stdout and stderr of the debuggee. However, if the DAP server is also outputting to stdout and stderr its messages will be mixed up with the debuggee's. This commit introduces a logging action to ensure it is possible to redirect all of the DAP server's output to a particular handle, thereby separating it from the debuggee. Fixes haskell-debugger#9
Introduces exception `TerminateServer` which, if thrown by a debugger session, is re-thrown to the main thread to terminate the server. This is useful if you are using the server in one-shot mode (only one execution per server)
dmjio
approved these changes
May 3, 2025
dmjio
reviewed
May 3, 2025
Comment on lines
+146
to
+151
| | Just TerminateServer <- fromException e | ||
| = do | ||
| logger logAction ERROR address Nothing | ||
| $ withBraces | ||
| $ T.pack ("Server terminated!") | ||
| throwTo serverThread (SomeAsyncException TerminateServer) |
dmjio
approved these changes
May 3, 2025
Contributor
|
@alt-romes hope I didn't prematurely merge this |
Collaborator
Author
|
No, that's alright! I'll close the other one since this one included that commit too. EDIT: Already has been closed automatically. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces exception
TerminateServerwhich, if thrown by a debugger session, is re-thrown to the main thread to terminate the server.This is useful if you are using the server in one-shot mode (only one execution per server)
This is based on #10