Simplify deployment by embedding assets into library. #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Johan,
we would like to use
ekg
at Erudify to monitor services deployed in our cloud. However, it's reliance on extra data files makes deploying applications built using it unnecessarily difficult. The attached patch uses thefile-embed
library to embed the necessary assets directly into theekg
library at compile time.It would be great, if you could change
ekg
to use this scheme. If required, then I can add either a cabal flag that allows to compile without embedding the files, or I can add an additional argument tostartServer
, which allows to specify the assets directory. I guess one would typically use the latter for development of the default monitor or for using a simple custom monitor. However, I do expect that for almost all use cases this direct embedding of the assets is the most convenient option.What do you think?
best regards,
Simon