cli: convert unix line-endings before parsing request #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleso
reviewed
Oct 25, 2016
| lineEndingsP = flag CRLF LF $ | ||
| short 'u' | ||
| <> long "unix-line-endings" | ||
| <> help "Convert UNIX line-endings into CRLF in the provided HTTP request." |
There was a problem hiding this comment.
I suppose it would be dodgy to try and detect the line endings rather than manually specifying it this way?
There was a problem hiding this comment.
I think so. The spec for the CLI was that it accepts a valid HTTP request on stdin and spits out a valid authenticated request on stdout; silently munging an invalid HTTP request (LF line endings) to make it valid without being told seems a bit broken IMO.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a convenience - it's difficult to manually construct valid HTTP requests using the usual UNIX tools without passing it through
unix2dosor similar first. Add an option to the CLI so we don't have to do that.Fixes #70.
! @charleso
(will follow up a more curl-friendly interface in #71)