Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please, bring changes so the newFailingTests are no more #966

Closed
4 of 5 tasks
Anton-Latukha opened this issue Jul 8, 2021 · 3 comments
Closed
4 of 5 tasks

Please, bring changes so the newFailingTests are no more #966

Anton-Latukha opened this issue Jul 8, 2021 · 3 comments

Comments

@Anton-Latukha
Copy link
Collaborator

Anton-Latukha commented Jul 8, 2021

Logical easiest progression: eval-okay-types -> eval-okay-hash -> eval-okay-hashfile

2021-07-08 list:

-- | New tests, which have never yet passed. Once any of these is passing,
-- please remove it from this list. Do not add tests to this list if they have
-- previously passed.
newFailingTests :: Set String
newFailingTests = Set.fromList
[ "eval-okay-hash"
, "eval-okay-hashfile"
, "eval-okay-path"
, "eval-okay-types"
, "eval-okay-fromTOML"
, "eval-okay-context-introspection"
]

💤 : eval-okay-fromTOML is of last concern. It used (as expected) only a couple of times in Nixpkgs.


@Anton-Latukha Anton-Latukha changed the title Please, change so the newFailingTests pass Please, change project so the newFailingTests pass Jul 8, 2021
@Anton-Latukha Anton-Latukha changed the title Please, change project so the newFailingTests pass Please, bring changes so the newFailingTests are no more Jul 8, 2021
@soulomoon
Copy link
Collaborator

soulomoon commented Jan 5, 2022

@Anton-Latukha
Copy link
Collaborator Author

Ok, #128 addressed the eval-okay-path.

Thanks, you closed this report.

@soulomoon
Copy link
Collaborator

I am glad that I helped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants