Expr.Types: add & use NPos & NSourcePos #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are to abstract over Megaparsec types which for `(<>)` use `+` but do not provide monoid. Also abstracting over these types allows to implement new positioning tht would work faster then current types.
`coerce` has problems coercing it in 8.10, so helping with it.
This is work towards: haskell-nix#1026 & haskell-nix#746.
Anton-Latukha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a type & type boundary lifting groundwork to do #1026 & #746 design in this release.
The
NPos&NSourcePosnext can be freely shaped into what comes out of the #1026 & #746.